fix: Apply FOV from previously-saved JSON files#389
Open
Thibaulltt wants to merge 2 commits intonmwsharp:masterfrom
Open
fix: Apply FOV from previously-saved JSON files#389Thibaulltt wants to merge 2 commits intonmwsharp:masterfrom
Thibaulltt wants to merge 2 commits intonmwsharp:masterfrom
Conversation
Author
|
I also noticed the wrong FOV was applied if you try to fly to the saved JSON view parameters, instead of applying them directly. Fixed in a4535be. |
Owner
|
Thanks for catching this! Is it good to go on your end now? |
Author
|
Yes! I would love to include a bit more info in the saved JSON, but that'll be for another week if I still need it then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It really bothered me that my FOV (and thus, the zoom) was not applied when loading a previously saved view JSON file. Found it was a typo in the deserialization :)
It should work for both the C++ and python functions, as long as polyscope-py gets a bump in its dependencies.